Skip to content

gha: trigger CI workflow after release to update API docs #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

philipnbbc
Copy link
Contributor

Details

The release trigger didn't work because the release used the GITHUB_TOKEN and that will not create a new workflow run - see Triggering a workflow from a workflow

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/187836655

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@philipnbbc philipnbbc requested a review from a team as a code owner July 2, 2024 09:32
Copy link
Contributor

@j616 j616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though I'm not sure the square brackets are needed for a single workflow. See https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#using-a-single-event

@philipnbbc
Copy link
Contributor Author

LGTM. Though I'm not sure the square brackets are needed for a single workflow. See https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#using-a-single-event

All the examples for workflow_run uses YAML list notation (square brackets or '-' child) for the workflows property and it doesn't mention a single workflow shortcut. I think then it's probably better to follow the examples.

@philipnbbc philipnbbc merged commit 633e509 into main Jul 2, 2024
5 checks passed
@philipnbbc philipnbbc deleted the philipn-update-api-docs-on-release branch July 2, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants