Skip to content

examples/outgest_file: Fix segment timerange check #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

philipnbbc
Copy link
Contributor

Details

The segment_timerange needs to overlap with the --timerange option (which defaults to TimeRange.eternity()`.

Jira Issue (if relevant)

Jira URL:

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Jira Issue (if relevant)
  • Follow-up stories added to Jira

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

The `segment_timerange` needs to overlap with the `--timerange` option
(which defaults to TimeRange.eternity()`.
@philipnbbc philipnbbc requested a review from a team as a code owner February 5, 2025 14:26
@philipnbbc philipnbbc merged commit ea9c7a9 into main Feb 10, 2025
5 checks passed
@philipnbbc philipnbbc deleted the philipn-fix-outgest-example-with-timerange branch February 10, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants