Skip to content

updated prelude rust module #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2022
Merged

updated prelude rust module #1388

merged 2 commits into from
Nov 21, 2022

Conversation

gerlacdt
Copy link
Contributor

@gerlacdt gerlacdt commented Nov 18, 2022

The current prelude-rust module used the deprecated rls lsp server.

With this PR, rls is replaced by the modern rust-analyzer lsp-server.
Additionally, tree-sitter was added for a nicer syntax highlighting for Rust code.

closes #1374


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality like modules, commands, configuration options, etc)

Thanks!

@bbatsov
Copy link
Owner

bbatsov commented Nov 21, 2022

Might have been better to split the LSP changes and the addition of tree-sitter in two commits, but it's not a big deal. At any rate - you should documented the usage of tree-sitter-mode for Rust in the module's doc.

@gerlacdt
Copy link
Contributor Author

I added a short description for syntax highlighting with tree-sitter-mode in the rust docs.
I hope, it's fine now.

@bbatsov bbatsov merged commit 54e3d81 into bbatsov:master Nov 21, 2022
@bbatsov
Copy link
Owner

bbatsov commented Nov 21, 2022

Thanks!

@gerlacdt gerlacdt deleted the feat/rust-mode branch November 21, 2022 21:27
OknoLombarda pushed a commit to OknoLombarda/prelude that referenced this pull request Dec 23, 2022
Use rust-analyzer as lsp server and tree-sitter for syntax highlighting.
suutari-ai added a commit to suutari-ai/prelude that referenced this pull request Jan 10, 2023
* 'master' of github.com:bbatsov/prelude:
  Remove helm-config.
  Update rust module (bbatsov#1388)
  Search sample/prelude-modules.el in prelude-dir during init
  Documentation for prelude orgmode
  Enable cleaner org-habits
  [Docs] Update the cheatsheet output (png and pdf).
  Fix copypasta in ruby.md
  Add magit-section to pinned packages
  Update installation.md
  Ignore eln-cache directory
  Minor typo fix
  [Docs] Mention flycheck-ocaml
  [Docs] Document the OCaml support
  Fix warning
  Add basic support for Literate Programming (bbatsov#1370)
  add last change to changelog
  Disable super-save on go-mode
  Document a workaround for fixing C-a in term-mode
  Bump the copyright years
  [bbatsov#1335] Workaround for which-key display bug (bbatsov#1349)
  Move go doc to new location (bbatsov#1366)
  GitHub actions CI (bbatsov#1362)
  Update of prelude-go to replace gocode backend with lsp-mode and gopls (bbatsov#1363)
  Fix contribute.md minor issues
  [DOCS] change pages to nav
  [DOCS] Add module for Rust language
  [DOCS] Add missing modules
  [DOCS] Formating text to 80 char lines and update available modules
  [DOCS] Update the Changelog
  [DOCS] Fix problem with Edit in github link
  [DOCS] Keep index.md to 80 char lines and a couple of minor edits
  Fix "Symbol's value as variable is void: kill-region" errors in Emacs 29.0.50 (bbatsov#1356)
stefankeidel added a commit to stefankeidel/emacs-config that referenced this pull request Apr 11, 2023
* upstream/master: (21 commits)
  Remove consult-apropos
  Add a Discord badge
  Add a CI badge to the README
  Add a missing section heading
  Add a missing provide
  Tweak the name of a helper function
  Add a missing require
  [Docs] Update the FAQ for use-package
  Tweak some changelog entries
  Prefer vertico over ivy
  Add a vertico module
  Auto-install use-package
  Bump the copyright years
  Fix installation of typescript-mode via prelude-ts (bbatsov#1398)
  Remove helm-config.
  Update rust module (bbatsov#1388)
  Search sample/prelude-modules.el in prelude-dir during init
  Documentation for prelude orgmode
  Enable cleaner org-habits
  [Docs] Update the cheatsheet output (png and pdf).
  ...
mklvr pushed a commit to mklvr/prelude that referenced this pull request Apr 11, 2023
Use rust-analyzer as lsp server and tree-sitter for syntax highlighting.
jmuhlich pushed a commit to jmuhlich/prelude that referenced this pull request May 23, 2023
Use rust-analyzer as lsp server and tree-sitter for syntax highlighting.
Bklyn pushed a commit to Bklyn/prelude that referenced this pull request Dec 30, 2023
Use rust-analyzer as lsp server and tree-sitter for syntax highlighting.
GEOFBOT pushed a commit to GEOFBOT/prelude that referenced this pull request Dec 4, 2024
Use rust-analyzer as lsp server and tree-sitter for syntax highlighting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please change Rust default LSP into Rust-Analyzer.
2 participants