Stop adding headers to ObjcProvider #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer needed. It was leftover from the compile info migration because (primarily) IDE still relied on it to get direct header information. We just migrated those use cases to CcInfo as well. PiperOrigin-RevId: 421189227 (cherry picked from commit d4ad14d)
brentleyjones
referenced
this pull request
Jan 12, 2022
This is no longer needed. It was leftover from the compile info migration because (primarily) IDE still relied on it to get direct header information. We just migrated those use cases to CcInfo as well. PiperOrigin-RevId: 421189227
keith
approved these changes
Jan 12, 2022
mattrobmattrob
added a commit
to mattrobmattrob/rules_ios
that referenced
this pull request
Dec 6, 2022
Remove the “hack” that propagates the `ObjcProvider.module_map` into `ObjcProvider.header` field since it doesn’t exist anymore. This is sorta like bazelbuild/rules_apple#1319 in `rules_apple`.
mattrobmattrob
added a commit
to bazel-ios/rules_ios
that referenced
this pull request
Dec 6, 2022
Remove the “hack” that propagates the `ObjcProvider.module_map` into `ObjcProvider.header` field since it doesn’t exist anymore. This is sorta like bazelbuild/rules_apple#1319 in `rules_apple`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer needed. It was leftover from the compile info
migration because (primarily) IDE still relied on it to get direct
header information. We just migrated those use cases to CcInfo as
well.
PiperOrigin-RevId: 421189227
(cherry picked from commit d4ad14d)