Run buildifier to add missing loads #7611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comius
requested review from
mai93,
ujohnny,
LeFrosch and
agluszak
as code owners
github-actions
bot
added
product: CLion
LeFrosch
requested changes
Apr 14, 2025
comius
force-pushed
the
add-loads
branch
2 times, most recently
from
86bc297 to
52fc60c
Compare
This was referenced Apr 15, 2025
LeFrosch
reviewed
Apr 15, 2025
| load("@protobuf//bazel:java_proto_library.bzl", "java_proto_library") | ||
| load("@protobuf//bazel:proto_library.bzl", "proto_library") | ||
| load("@rules_java//java:defs.bzl", "java_library") |
There was a problem hiding this comment.
Just a question, why are there two different kinds of loads:
load("@rules_java//java:defs.bzl", "java_library")load("@rules_java//java:java_library.bzl", "java_library")
There was a problem hiding this comment.
defs.bzl is older (and legacy). At the moment we're advising everybody to use <symbol>.bzl. This results in minimal loads (defs.bzl needs to load everything, and by accident there java_proto_library in rules_java, that pulls down protobuf).
If there's a preexisting use of defs.bzl, buildifier won't touch it.
… aspect, needs template
|
Since release is done, I'd suggest we merge this now? @ujohnny |
github-project-automation
bot
moved this from Untriaged
to Done
in Bazel IntelliJ Plugin
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
buildifier --lint=fix -r -v. This addloadsfor the rules that were removed from Bazel 8. By Bazel 9 automatic loads will be disabled and all loads will need to be explicitly present.Some loads that cause test failures are omitted and should be done in a separate PRs.
See: bazelbuild/bazel#25755