[AOSP-pick] Add/Update getLocalFiles method to support both BlazeArtifact and OutputArtifact type artifacts #7508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
…putArtifact type artifacts - Add a method getLocalFilesForLegacySync to support processing BlazeArtifact artifact types. - Update existing getLocalFiles method to fetch local files for OutputArtifact type artifacts. - This will help migrate LocalFileArtifact#getLocalFiles to using RuntimeArtifactCache, which only supports OutputArtifact (as it expects artifacts to contain a digest). - Invokers of the method has been updated based on whether the flow is used in LegacySync or QuerySync (Native debugging). Bug: 385469770 Test: Existing tests for testing old and new methods as their implementation will only be updated in next CLs. Change-Id: I6b7ecfd522f086b712c99e90fe30f1b3b3cb7abe Change-Id: I523e59d72a3c239b234e0112c76b128e2bc19fb7 AOSP: ed8535e5178e2f3f0459e7c01de1902fb319d4c5
LeFrosch
force-pushed
the
AOSP/ed8535e5178e2f3f0459e7c01de1902fb319d4c5
branch
from
eb1be36 to
10bcaa5
Compare
sellophane
approved these changes
Mar 27, 2025
github-project-automation
bot
moved this from Untriaged
to Done
in Bazel IntelliJ Plugin
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick AOSP commit ed8535e5178e2f3f0459e7c01de1902fb319d4c5.
STAT (diff to AOSP): 0 insertions(+), 0 deletion(-)
BlazeArtifact artifact types.
only supports OutputArtifact (as it expects artifacts to contain a
digest).
used in LegacySync or QuerySync (Native debugging).
Bug: 385469770
Test: Existing tests for testing old and new methods as their
implementation will only be updated in next CLs.
Change-Id: I6b7ecfd522f086b712c99e90fe30f1b3b3cb7abe
Change-Id: I523e59d72a3c239b234e0112c76b128e2bc19fb7
AOSP: ed8535e5178e2f3f0459e7c01de1902fb319d4c5