Followup: Use toolchains_aspects to propagate aspects to toolchains #7376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
mai93
reviewed
Mar 1, 2025
| @@ -15,8 +17,11 @@ java_binary( | |||
| ], | |||
| ) | |||
|
|
|||
| bazel_integration_tests( | |||
| bazel_integration_test( | |||
There was a problem hiding this comment.
did this disable the tests against older versions of bazel? I do not see it in the test result https://buildkite.com/bazel/intellij-plugin-aspect/builds/24766#01954c26-b10e-4a63-8d88-38d1b7f04258
There was a problem hiding this comment.
Yes it does. Because the integration tests do not support templating and therefore it is not possible to target multiple bazel versions with these changes.
mai93
approved these changes
Mar 3, 2025
|
Looks good and probably we'll remove the test since we have new integration tests that do the job during bazel 9 migration, because the test is still using workspace and probably does not make any sense to update it to bzlmod. |
ujohnny
approved these changes
Mar 7, 2025
Since the aspect templating does not work for aspect integration tests we cannot target multiple bazel versions.
LeFrosch
force-pushed
the
toolchains-aspect
branch
from
88e27ab to
648bbec
Compare
github-project-automation
bot
moved this from Untriaged
to Done
in Bazel IntelliJ Plugin
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for: #7300