[AOSP-pick] Never ask for artifacts without output group #7366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Builds may get multiple aspects applied resulting in multiple additional artifacts returned. 2. Make `getOutputGroupTargetArtifacts` return all artifacts declared by the target as its outputs instead of ambiguously defined direct artifacts, which in its current implementation is implementation dependent and returns top level named file sets only. Note, a single target may itself produce multiple nested file sets without participation of other targets at all. File sets basically follow the structure fo depsets. Perhaps the amount of logging in callers reflects the incorrect behavior. 3. When requesting `AndroidDeployInfo` from local build mirror the implementation providing support for remote builds and pass the output group name explicitly. note, these two implementations need to converged before they can be merged. Bug: 385469770 Bug: 327638725 Test: existing Change-Id: Idfb90474e74cd6e4fa9978452f687138c69df13c AOSP: b228d1ef2bdb093b73203176ec8158061042505e
github-actions
bot
added
product: CLion
LeFrosch
approved these changes
Feb 26, 2025
github-project-automation
bot
moved this from Untriaged
to Done
in Bazel IntelliJ Plugin
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick AOSP commit b228d1ef2bdb093b73203176ec8158061042505e.
Builds may get multiple aspects applied resulting in multiple
additional artifacts returned.
Make
getOutputGroupTargetArtifactsreturn all artifacts declared bythe target as its outputs instead of ambiguously defined direct
artifacts, which in its current implementation is implementation
dependent and returns top level named file sets only. Note, a single
target may itself produce multiple nested file sets without
participation of other targets at all. File sets basically follow the
structure fo depsets. Perhaps the amount of logging in callers
reflects the incorrect behavior.
When requesting
AndroidDeployInfofrom local build mirror theimplementation providing support for remote builds and pass the
output group name explicitly. note, these two implementations need
to converged before they can be merged.
Bug: 385469770
Bug: 327638725
Test: existing
Change-Id: Idfb90474e74cd6e4fa9978452f687138c69df13c
AOSP: b228d1ef2bdb093b73203176ec8158061042505e