Reduce freeze in ProjectUpdater #7199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
sellophane
force-pushed
the
project_update_freezes_fix
branch
3 times, most recently
from
eb1b62b to
5f0db19
Compare
sellophane
force-pushed
the
project_update_freezes_fix
branch
from
5f0db19 to
6a841fd
Compare
LeFrosch
reviewed
Jan 14, 2025
base/src/com/google/idea/blaze/base/qsync/ProjectUpdaterThreadingUtils.kt
Show resolved
Hide resolved
sellophane
force-pushed
the
project_update_freezes_fix
branch
from
6a841fd to
ca80922
Compare
sellophane
force-pushed
the
project_update_freezes_fix
branch
from
fb22b90 to
5600551
Compare
odisseus
approved these changes
Feb 26, 2025
| } | ||
| return new AbstractMap.SimpleImmutableEntry<>(module, moduleSpec); | ||
| }).toList(); | ||
| return new AbstractMap.SimpleImmutableEntry<>(models, modules); |
There was a problem hiding this comment.
Weird choice of type. Is this just a pair of values?
| @@ -135,90 +142,98 @@ private void updateProjectModel(ProjectProto.Project spec, Context<?> context) { | |||
| } | |||
| ImmutableMap<String, Library> libMap = libMapBuilder.buildOrThrow(); | |||
|
|
|||
| for (ProjectProto.Module moduleSpec : spec.getModulesList()) { | |||
There was a problem hiding this comment.
IMO the good old for loop is more readable in this case.
|
|
||
| /** An object that monitors the build graph and applies the changes to the project structure. */ | ||
| import static com.google.common.collect.ImmutableList.toImmutableList; |
There was a problem hiding this comment.
Why the import reshuffling? Is this enforced by CI?
Comment on lines
209
to
210
| }, | ||
| readValue -> { |
There was a problem hiding this comment.
We're in the middle of a method call which spans more than 100 lines. Why not extract some private methods?
sellophane
force-pushed
the
project_update_freezes_fix
branch
from
5600551 to
612938f
Compare
sellophane
force-pushed
the
project_update_freezes_fix
branch
from
612938f to
d198b02
Compare
odisseus
approved these changes
Feb 28, 2025
github-project-automation
bot
moved this from Untriaged
to Done
in Bazel IntelliJ Plugin
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
https://github.com/bazelbuild/intellij/issues/7149Description of this change