handling for debugging python test targets with transitions #7198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
andponlin-canva
force-pushed
the
handle-transition-py-rules-on-debugger
branch
from
4735bbe to
88f37b6
Compare
|
Note that an example project exhibiting the problem has been added to the issue. |
andponlin-canva
force-pushed
the
handle-transition-py-rules-on-debugger
branch
from
6fac996 to
65dc1de
Compare
|
Pushed to resolve a tree conflict. |
andponlin-canva
force-pushed
the
handle-transition-py-rules-on-debugger
branch
from
65dc1de to
d119afd
Compare
sellophane
approved these changes
Feb 12, 2025
sellophane
force-pushed
the
handle-transition-py-rules-on-debugger
branch
from
d119afd to
ac027d8
Compare
github-actions
bot
removed
the
awaiting-review
odisseus
reviewed
Feb 12, 2025
| @@ -58,7 +60,7 @@ public Future<Collection<TargetInfo>> targetsForSourceFiles( | |||
| if (projectData == null) { | |||
| return Futures.immediateFuture(ImmutableList.of()); | |||
| } | |||
| ImmutableSet<TargetInfo> targets = | |||
| List<TargetInfo> targets = | |||
There was a problem hiding this comment.
This collection should be immutable.
There was a problem hiding this comment.
This is handled here in a new PR
| @@ -85,11 +89,13 @@ public Future<Collection<TargetInfo>> targetsForSourceFiles( | |||
| if (targetMap == null) { | |||
| return Futures.immediateFuture(ImmutableList.of()); | |||
| } | |||
| ImmutableSet<TargetInfo> targets = | |||
| List<TargetInfo> targets = | |||
There was a problem hiding this comment.
This is handled here in a new PR.
odisseus
added a commit
to VirtuslabRnD/intellij
that referenced
this pull request
Feb 12, 2025
3 tasks
odisseus
added a commit
to VirtuslabRnD/intellij
that referenced
this pull request
Feb 12, 2025
andponlin-canva
added a commit
to andponlin-canva/bazelbuild_intellij
that referenced
this pull request
Feb 12, 2025
A prior pr bazelbuild#7198 introduced some stream handling. It was later pointed out that the collection of the stream should be immutable; this PR will fix that.
anguslees
reviewed
Feb 12, 2025
| "_java_grpc_library", "_kotlin_library", "_java_lite_grpc_library", "_iml_module_", | ||
| "cc_library", "cc_binary", "cc_shared_library", "cc_test", "proto_library", "py_library", | ||
| "py_binary", "py_test") | ||
| .flatMap(k -> Stream.of(k, "_transition_" + k)) |
There was a problem hiding this comment.
Nit: This is a regex, right? I think "(_transition_)?(" + kindsExpression + ")" matches the same cases without doubling back tracking cost.
There was a problem hiding this comment.
Hi @anguslees ; I experimented with this and although my testing method is rough, there does seem to be a very small improvement with the approach you are suggesting over a large project. I do get the same results either way. I will try come back to this and swap the implementation out.
There was a problem hiding this comment.
See here for a PR covering this suggestion. Thanks; that is much more elegant in any case.
andponlin-canva
added a commit
to andponlin-canva/bazelbuild_intellij
that referenced
this pull request
Feb 14, 2025
A prior pr bazelbuild#7198 introduced ability for Bazel queries to handle Rules that have transitions applied to them. This change introduced a modified Bazel query used in the plugin. This commit will optimize the query so it is more compact and performs slightly better.
3 tasks
LeFrosch
pushed a commit
that referenced
this pull request
Feb 14, 2025
sellophane
pushed a commit
to andponlin-canva/bazelbuild_intellij
that referenced
this pull request
Feb 21, 2025
A prior pr bazelbuild#7198 introduced ability for Bazel queries to handle Rules that have transitions applied to them. This change introduced a modified Bazel query used in the plugin. This commit will optimize the query so it is more compact and performs slightly better.
andponlin-canva
added a commit
to andponlin-canva/bazelbuild_intellij
that referenced
this pull request
Feb 24, 2025
A prior pr bazelbuild#7198 introduced ability for Bazel queries to handle Rules that have transitions applied to them. This change introduced a modified Bazel query used in the plugin. This commit will optimize the query so it is more compact and performs slightly better.
sellophane
pushed a commit
to andponlin-canva/bazelbuild_intellij
that referenced
this pull request
Feb 25, 2025
A prior pr bazelbuild#7198 introduced ability for Bazel queries to handle Rules that have transitions applied to them. This change introduced a modified Bazel query used in the plugin. This commit will optimize the query so it is more compact and performs slightly better.
sellophane
pushed a commit
to andponlin-canva/bazelbuild_intellij
that referenced
this pull request
Feb 25, 2025
A prior pr bazelbuild#7198 introduced ability for Bazel queries to handle Rules that have transitions applied to them. This change introduced a modified Bazel query used in the plugin. This commit will optimize the query so it is more compact and performs slightly better.
sellophane
pushed a commit
that referenced
this pull request
Feb 25, 2025
A prior pr #7198 introduced ability for Bazel queries to handle Rules that have transitions applied to them. This change introduced a modified Bazel query used in the plugin. This commit will optimize the query so it is more compact and performs slightly better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: 7196
Description of this change
_transition_prefix as being the Kind with with_transition_prefix stripped._prefix.rules_pythonPyInfoprovider to be considered with Bazel < 8. I am unsure of all the wider ramifications of this so it may require some discussion. I think internal Bazel rules were dropped on Bazel 5 so perhaps it is a reasonable assumption that the user would be usingrules_pythonif they are using Python at all?