Lazily create local symlinks with BwoB #26045
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @tjgq |
fmeum
force-pushed
the
21747-remote-only-symlinks
branch
7 times, most recently
from
b7886e5 to
0847339
Compare
github-actions
bot
added
team-Performance
|
@tjgq Bump on this, would be great to get into 8.3.0 rc1 🙏. |
fmeum
force-pushed
the
21747-remote-only-symlinks
branch
2 times, most recently
from
9c1fe35 to
2adab54
Compare
Unconditionally creating symlinks results in unnecessary I/O and may not even be supported by the host (e.g. on Windows). Instead, only create it in the remote action file system and rely on the prefetcher to materialize it when needed by downstream actions.
fmeum
force-pushed
the
21747-remote-only-symlinks
branch
from
2adab54 to
e5b350e
Compare
|
I won't be able to review this in time for 8.3.0, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unconditionally creating symlinks results in unnecessary I/O and may not even be supported by the host (e.g. on Windows). Instead, only create symlinks in the remote action file system and rely on the prefetcher to materialize them when needed by downstream actions. This applies to both "alias" symlinks (
declare_file, but materialized as a symlink to some other file) and "unresolved" symlinks (declare_symlink).Fixes #21747
RELNOTES[inc]: Symlinks are now treated just like regular files with
--remote_download_minimaland--remote_download_topleveland may not be materialized on disk if not requested explicitly. Symlinks created for outputs declared viactx.actions.declare_filemay now be materialized with absolute target paths, even when the action creating them uses a relative symlink. Usectx.actions.declare_symlinkfor precise control over the target path.