Skip to content

Add link to the official Dockerfile config #23072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jjmaestro
Copy link
Contributor

It's nice to be able to find the Dockerfile for any image easily, so I'm just adding the link to the "Getting Started with Bazel Docker Container" doc.

Maybe it was probably me not knowing how to navigate the Container Registry website but I couldn't find the Dockerfile for the official images. In fact, it was a bit confusing because, while googling, I did find some old versions of the website that pointed to an old registry with very old images!

Luckily, trying to find what was going on, I found bazelbuild/continuous-integration issue #1060 and from there, I found the Dockerfile for the official image.

It's nice to be able to find the Dockerfile for any image easily, so I'm just adding the link to the "Getting Started with Bazel Docker Container" doc.

Maybe it was probably me not knowing how to navigate the Container Registry website but I couldn't find the Dockerfile for the official images. In fact, it was a bit confusing because, while googling, I did find some old versions of the website that pointed to an old registry with very old images!

Luckily, trying to find what was going on, I found [bazelbuild/continuous-integration issue bazelbuild#1060](bazelbuild/continuous-integration#1060) and from there, I found the Dockerfile for the official image.
Copy link

google-cla bot commented Jul 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Jul 23, 2024
@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jul 23, 2024
@jjmaestro
Copy link
Contributor Author

@sgowroji how can I get this PR reviewed? It's just a one-line comment in the docs... 😅 And... somehow, it's failing some CI jobs with what looks like flaky errors not related to the PR :-/

Thanks!

@sgowroji
Copy link
Member

Cc @meteorcloudy

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 12, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants