Skip to content

Add more profiler spans to diff handling #22622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 3, 2024

On an incremental build with --watchfs, the handleDiffs span in the timing profile is now almost fully explained by subspans.

On an incremental build with `--watchfs`, the `handleDiffs` span in the timing profile is now almost fully explained by subspans.
@fmeum fmeum requested a review from meisterT June 3, 2024 19:55
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jun 3, 2024
@sgowroji sgowroji added the team-Core Skyframe, bazel query, BEP, options parsing, bazelrc label Jun 4, 2024
@meisterT meisterT added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 4, 2024
@copybara-service copybara-service bot closed this in f4b4537 Jun 4, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 4, 2024
@fmeum fmeum deleted the better-profile branch June 4, 2024 21:01
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 4, 2024

@bazel-io fork 7.2.0

bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jun 4, 2024
On an incremental build with `--watchfs`, the `handleDiffs` span in the timing profile is now almost fully explained by subspans.

Closes bazelbuild#22622.

PiperOrigin-RevId: 640084976
Change-Id: Iab7c9f22bab5e53cfab1d39dc0b3f2a697453540
github-merge-queue bot pushed a commit that referenced this pull request Jun 4, 2024
On an incremental build with `--watchfs`, the `handleDiffs` span in the
timing profile is now almost fully explained by subspans.

Closes #22622.

PiperOrigin-RevId: 640084976
Change-Id: Iab7c9f22bab5e53cfab1d39dc0b3f2a697453540

Commit
f4b4537

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants