[7.0.0] android_local_test isn't compatible with Android Platforms
#20215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove `target_compatible_with` from the Android toolchains generated in the Starlark and native `android_sdk_repository` rules so that they can be selected with a host JDK in android_local_test 1. Re-enable `android_local_test_integration_test.sh` 1. Switch `--platforms` to `--android_platforms` in the android integration test setup so that a host JDK can be selected in android_local_test Fixes bazelbuild#19829 RELNOTES: None PiperOrigin-RevId: 582716155 Change-Id: I49d6a9058218d522b9ebb7cc6842fe20c36e2798
bazel-io
added
team-Android
|
Only 9bbc2cb was cherry-picked since the issue was closed with this commit, but let me know if we need to include updates from the other CL as well (once submitted). |
katre
approved these changes
Nov 15, 2023
|
Should this also mark #19883 as fixed? |
|
Yes, I'll close #19883 once this is merged. |
github-actions
bot
removed
the
awaiting-review
|
Maybe we can append a line like |
|
So this unfortunately doesn't work with PRs against non-default branches (doc). But I believe @iancha1992 is looking into creating a small workflow that automatically closes these blocker issues. |
|
Oh, I see! Thanks, I didn't know that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
target_compatible_withfrom the Android toolchains generated in the Starlark and nativeandroid_sdk_repositoryrules so that they can be selected with a host JDK in android_local_testRe-enable
android_local_test_integration_test.shSwitch
--platformsto--android_platformsin the android integration test setup so that a host JDK can be selected in android_local_testFixes #19829
RELNOTES: None
Commit 9bbc2cb
PiperOrigin-RevId: 582716155
Change-Id: I49d6a9058218d522b9ebb7cc6842fe20c36e2798