Skip to content

[6.3.0] Teach ijar about dynamic constants. #18711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

iancha1992
Copy link
Member

Teach ijar about dynamic constants.

Fixes #18360

Closes #18406

Commit 69d2991

PiperOrigin-RevId: 540750474
Change-Id: If61bcaaf018b92a1bf87335c1075c28294932b1f

PR bazelbuild#18406: Teach ijar about dynamic constants.

Imported from GitHub PR bazelbuild#18406

END_PUBLIC

PiperOrigin-RevId: 540750474
Change-Id: If61bcaaf018b92a1bf87335c1075c28294932b1f
@iancha1992 iancha1992 added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Jun 16, 2023
@iancha1992 iancha1992 requested a review from cushon June 16, 2023 17:19
@google-cla
Copy link

google-cla bot commented Jun 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@iancha1992 iancha1992 enabled auto-merge (squash) June 16, 2023 17:19
@cushon
Copy link
Contributor

cushon commented Jun 16, 2023

@iancha1992 this PR was already imported: 69d2991

edit: I missed this was for the 6.3.0 branch, sorry

@iancha1992
Copy link
Member Author

iancha1992 commented Jun 16, 2023

@benjaminp our team is trying to cherry-pick this for release-6.3.0. However, looks like in order to merge your work, we have to have you sign the Contributor License Agreement (CLA), which is a one-time process, and only takes a minute. Please refer to this: https://github.com/bazelbuild/bazel/pull/18711/checks. Thank you

@benjaminp
Copy link
Collaborator

Somehow 69d2991 was imported/exported under my personal email rather than my work email, which is listed under a corporate CLA. Perhaps you can change the address of the commit in this PR? (See any of my other commits in this repository for it.)

@iancha1992 iancha1992 closed this Jun 20, 2023
auto-merge was automatically disabled June 20, 2023 19:50

Pull request was closed

@iancha1992
Copy link
Member Author

iancha1992 commented Jun 20, 2023

Closing this PR because I just amended the commit's author email for CLA compliance. There is another PR #18729

@iancha1992 iancha1992 removed the request for review from cushon June 20, 2023 19:59
@iancha1992 iancha1992 removed team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants