Update the open source filegroup rule to disable toolchain resolution. #13194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal version of this rule has toolchain resolution disabled, and this has been widely documented, so it is easiest to update the external version of the rule to match.
gregestren
approved these changes
Mar 10, 2021
|
@philsc Argh, you're right. Okay, I need a better solution to this. |
katre
added a commit
to katre/bazel
that referenced
this pull request
Mar 15, 2021
This reverts dce861d, which was a mistake. It also removes a test which is now useless. There are no more build rules (which have the target_compatible_with attribute for target skipping) which also have toolchain resolution disabled, so this cannot be tested for. Fixes bazelbuild#12899 and undoes bazelbuild#13194.
bazel-io
pushed a commit
that referenced
this pull request
Mar 16, 2021
This reverts dce861d, which was a mistake. It also removes a test which is now useless. There are no more build rules (which have the target_compatible_with attribute for target skipping) which also have toolchain resolution disabled, so this cannot be tested for. Fixes #12899 and undoes #13194. Closes #13223. PiperOrigin-RevId: 363200655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal version of this rule has toolchain resolution disabled, and
this has been widely documented, so it is easiest to update the external
version of the rule to match.