Force /usr/bin/python2.7 on macOS #12072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of this issue bazelbuild#12049 this call to python doesn't respect the PATH users invoke bazel with. Because the default shell path contains /usr/local/bin, this `python` could end up being from homebrew. Homebrew's python installations are easily borked which leads to hashlib being unusable: https://discuss.bitrise.io/t/broken-python-2-7-hashlib-in-new-xcode-10-3-x-mojave-stack/11401/7 This changes this use case to a path that always exists (at least for now) on macOS, and only falls back to the bare executable if it doesn't. Ideally this would utilize the python version from the toolchain instead.
keith
force-pushed
the
ks/force-python27-on-macos
branch
from
cbebe9b to
8306d24
Compare
segiddins
approved these changes
Oct 1, 2020
Yannic
pushed a commit
to Yannic/bazel
that referenced
this pull request
Oct 5, 2020
Because of this issue bazelbuild#12049 this call to python doesn't respect the PATH users invoke bazel with. Because the default shell path contains /usr/local/bin, this `python` could end up being from homebrew. Homebrew's python installations are easily borked which leads to hashlib being unusable: https://discuss.bitrise.io/t/broken-python-2-7-hashlib-in-new-xcode-10-3-x-mojave-stack/11401/7 This changes this use case to a path that always exists (at least for now) on macOS, and only falls back to the bare executable if it doesn't. Ideally this would utilize the python version from the toolchain instead. Closes bazelbuild#12072. PiperOrigin-RevId: 335109991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of this issue #12049
this call to python doesn't respect the PATH users invoke bazel with.
Because the default shell path contains /usr/local/bin, this
pythoncould end up being from homebrew. Homebrew's python installations are
easily borked which leads to hashlib being unusable:
https://discuss.bitrise.io/t/broken-python-2-7-hashlib-in-new-xcode-10-3-x-mojave-stack/11401/7
This changes this use case to a path that always exists (at least for
now) on macOS, and only falls back to the bare executable if it doesn't.
Ideally this would utilize the python version from the toolchain
instead.