Skip to content

Migrate unit and integration tests to Python 3 #7903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brandjon opened this issue Mar 30, 2019 · 1 comment
Closed

Migrate unit and integration tests to Python 3 #7903

brandjon opened this issue Mar 30, 2019 · 1 comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Python Native rules for Python type: process

Comments

@brandjon
Copy link
Member

With #6647 we flip the default Python version to PY3, but we opt out of this change for our own unit and integration tests. We should eventually port these tests to Python 3 and remove the opt-out.
@brandjon brandjon added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: process team-Rules-Python Native rules for Python labels Mar 30, 2019
@brandjon brandjon mentioned this issue Jun 20, 2019
Closed
copybara-service bot pushed a commit that referenced this issue May 31, 2022
@rickeylev @copybara-github
Default analysis tests to use Python 3
93f6e51 
This matches the behavior outside of the tests.

Work towards #7903

PiperOrigin-RevId: 452140874
Change-Id: Icab37d01657b07ef6f56366a1e0b64f0f3d26c29
@sgowroji sgowroji added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 16, 2023
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

@sgowroji sgowroji closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Python Native rules for Python type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandjon @sgowroji