Skip to content

[Bazel6] Add CcInfo to precompiled_apple_resource_bundle #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

[Bazel6] Add CcInfo to precompiled_apple_resource_bundle #622

merged 1 commit into from
Dec 5, 2022

Conversation

mattrobmattrob
Copy link
Collaborator

@mattrobmattrob mattrobmattrob commented Dec 5, 2022 •
edited
Loading

This allows it to pass the CcInfo provider requirement for the objc_library.deps attribute:

https://github.com/bazelbuild/bazel/blob/7ccc66108f08f7b6c6f6e5229f70f29962ea19ce/src/main/starlark/builtins_bzl/common/objc/attrs.bzl#L88-L91

Release notes associated with the change/attribute:

RELNOTES[INC]: objc_library now requires CcInfo in its deps. If this breaks you, add empty CcInfo() to your rule.

@mattrobmattrob mattrobmattrob mentioned this pull request Dec 5, 2022
Merged
@mattrobmattrob mattrobmattrob marked this pull request as ready for review December 5, 2022 19:32
@mattrobmattrob mattrobmattrob enabled auto-merge (squash) December 5, 2022 19:32
@mattrobmattrob mattrobmattrob enabled auto-merge (squash) December 5, 2022 19:32
@mattrobmattrob mattrobmattrob merged commit 8dc0075 into bazel-ios:master Dec 5, 2022
@mattrobmattrob mattrobmattrob deleted the mr/bazel6/precompiled.apple.resource.bundle.CcInfo branch December 5, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrymarino jerrymarino jerrymarino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattrobmattrob @jerrymarino