[Bazel6] Handle removal of ObjcProvider.direct_headers
#620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle bazelbuild/bazel#14559 (bazelbuild/bazel@8a2b711) to prepare for Bazel 6 but still work in Bazel 5.
jerrymarino
approved these changes
Dec 3, 2022
| @@ -410,7 +410,7 @@ def _get_direct_public_headers(provider, dep): | |||
| return [] | |||
| return dep[provider].compilation_context.direct_public_headers | |||
| elif provider == apple_common.Objc: | |||
| return dep[provider].direct_headers | |||
| return getattr(dep[provider], "direct_headers", []) | |||
There was a problem hiding this comment.
@mattrobmattrob so the gist is that the previous condition is hit on Bazel 6. LGTM overall
There was a problem hiding this comment.
I didn't confirm that but as far as I can tell, yes. At least for all the cases tested by my code and the CI suite.
luispadron
approved these changes
Dec 3, 2022
mattrobmattrob
deleted the
mr/bazel6/clean.up.ObjcProvider.direct_headers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle bazelbuild/bazel#14559 (bazelbuild/bazel@8a2b711) to prepare for Bazel 6 but still work in Bazel 5.