feat: allow customizing $PATH during rb_bundle_fetch
#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushain97
changed the title
$PATH during `rb_bundle_fetch$PATH during rb_bundle_fetch
p0deje
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we're overwriting
$PATHregardless of what the user specifies inenv. With this change, we use the user's provided value in addition to adding our own entry.This is necessary for some gems that depend on system binaries. For example, the
pggem depends onpg_configbinary.Bazel already adds some standard directories like
/usr/local/binto$PATH. But, that isn't sufficient on recent versions of MacOS because Homebrew stores packages elsewhere (see bazelbuild/bazel#12049).This change allows users who are comfortable with not fully hermetic bundle builds to opt into it by tweaking
$PATH.