Skip to content

Export new location of support files needed for using Go's WASM output. #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Apr 19, 2025

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

In order to run code with GOOS=js GOARCH=wasm in the browser, you need to copy a .js file from the toolchain.
This file location was changed in Go 1.24, which is now also exported in this PR.

Which issues(s) does this PR fix?

n/a

Other notes for review

See also this info from the Go wiki:

For Go 1.23 and earlier, the wasm support files needed in this article are located in misc/wasm, and the path should be replaced when performing operations with files such as lib/wasm/wasm_exec.js.

source

@malt3
Copy link
Contributor Author

malt3 commented Apr 19, 2025

I see, I'll need to update the glob to match the old and the new path in one pattern.

@fmeum
Copy link
Member

fmeum commented Apr 19, 2025

That's even better

@malt3 malt3 force-pushed the wasm_exec_js_in_lib branch 2 times, most recently from 5858ab0 to 1e8727c Compare April 20, 2025 08:39
@fmeum fmeum force-pushed the wasm_exec_js_in_lib branch from 1e8727c to fa598a5 Compare May 2, 2025 11:33
@fmeum fmeum enabled auto-merge (squash) May 2, 2025 11:33
@fmeum fmeum disabled auto-merge May 2, 2025 11:33
@fmeum fmeum enabled auto-merge (squash) May 2, 2025 11:33
@fmeum fmeum merged commit 187ba67 into bazel-contrib:master May 2, 2025
1 check passed
@malt3 malt3 deleted the wasm_exec_js_in_lib branch May 2, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants