deps: Get repositories.bzl in sync with go.mod #4316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to update repositories.bzl to stay in sync with go.mod, but ideally we don't want to avoid updates in go.mod. This requires updating the tool to be able to request a specific version rather than just updating to the latest. When requesting a package at a specific version, the comment should not claim that it was "latest" as of today.
Bump the versions of dependencies in repositories.bzl to match what's in go.mod. Specifically bumps: - golang.org/x/sys - google.golang.org/protobuf - google.golang.org/grpc/cmd/protoc-gen-go-grpc - google.golang.org/genproto - github.com/golang/mock Closes bazel-contrib#4262
adam-azarchs
force-pushed
the
azarchs/sync-repositories
branch
from
211a6bf to
f10d0f8
Compare
|
Some examples are failing to compile with the updated grpc. Which is weird because they should have been failing already under with bzlmod, where they'd have been using what's in |
|
I guess maybe I'll just revert the changes to |
Breaks some tests, so not unlikely that it would also break other people.
fmeum
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the versions of dependencies in repositories.bzl to match what's in
go.mod.
Specifically bumps:
Additionally add features to the
releasertool for updating to a specific version, rather than latest, so we can avoid further modifications togo.mod.Fixes #4262