fix(cgo): exclude crypto/internal/sysrand/internal/seccomp from SDK srcs #4311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package fails to compile with linux kernel sources prior to 3.17. It's an internal package that is only used by unit tests, so compiling it as part of the monolithic SDK target is a waste of time anyway, so just exclude it. Closes bazel-contrib#4310
fmeum
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
The
crypto/internal/sysrand/internal/seccomppackage fails to compile with linux kernel sources prior to 3.17. It's an internal package that is only used by unit tests, so compiling it as part of the monolithic SDK target is a waste of time anyway, so just exclude it.Which issues(s) does this PR fix?
Fixes #4310