Add wrap extension tag to implement go_wrap_sdk #4301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Mar 25, 2025
There was a problem hiding this comment.
Looks good, thanks!
I would have expected https://github.com/bazel-contrib/bazel-gazelle/blob/186298911d38850b47b198e8d933a93125ce7043/docs/BUILD.bazel#L17 to fail though. Could you check what happens if you run //docs:update?
That is gazelle. Looks like rules_go also has //docs:update but it was fine. |
Add all wrapped sdks to the beginning of the toolchains so any specific platforms override the downloaded toolchain. Add a test that transitions to a different sdk from the downloaded version. The test asserts the correct version.
fmeum
force-pushed
the
patrick/wrap-extension
branch
from
e2c45eb to
67627b7
Compare
fmeum
approved these changes
Mar 25, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all wrapped sdks to the beginning of the toolchains so any specific platforms override the downloaded toolchain.
Add a test that transitions to a different sdk from the downloaded version. The test asserts the correct version.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #4300
Other notes for review