Escape backslashes and newlines in response files #4297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Mar 24, 2025
fmeum
reviewed
Mar 24, 2025
alopezz
changed the title
fmeum
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
It escapes backlashes by doubling them when using response files. Without this, builds that trigger the usage of response files fail with:
This comes from this line of code in the Go compiler, which complains if a backlash is not followed either by another
\or byn.Which issues(s) does this PR fix?
Fixes #4112 (I'd expect).
Other notes for review
I'd be happy to add a test but that function is not written in a very testable way (and I'm not sure the response files feature as a whole has any tests). As it is and without more significant changes I don't think it would be possible to write a test for it.