Skip to content

Preserve nogo runfiles #4270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Preserve nogo runfiles #4270

merged 1 commit into from
Feb 18, 2025

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Feb 13, 2025

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Which issues(s) does this PR fix?

Fixes #4255

Other notes for review

Copy link
Contributor

@DolceTriade DolceTriade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me! I verified that the Go runfiles library works as expected within analyzers!

@fmeum fmeum force-pushed the 4255-nogo-runfiles branch from 08eed62 to f5e0a5f Compare February 18, 2025 07:49
@fmeum fmeum merged commit c0bf665 into master Feb 18, 2025
4 checks passed
@fmeum fmeum deleted the 4255-nogo-runfiles branch February 18, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nogo doesn't propagate analyzer runfiles to the final binary
2 participants