gomock: allow passing extra flags to mockgen_tool #4066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
TvdW
force-pushed
the
mockgen
branch
2 times, most recently
from
e9c259f to
2311def
Compare
This reverts commit 4feb7b8. Not needed anymore if we add generic `mockgen_args`
|
Sure, done! |
fmeum
approved these changes
Aug 28, 2024
tyler-french
pushed a commit
that referenced
this pull request
Aug 30, 2024
tyler-french
pushed a commit
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Adds the ability to pass extra arguments to gomock
Which issues(s) does this PR fix?
Fixes #4065
Closes #4067
Other notes for review
#4067 is another way to do it, but I think accepting an argument list is cleaner