feat: add run_binary with output directory support & improved makevar expansion #57
Conversation
gregmagolan
force-pushed
the
run_binary_with_dir
branch
2 times, most recently
from
0690fdc to
ee35d14
Compare
| doc = "Command line arguments of the binary.<br/><br/>Subject to" + | ||
| "<code><a href=\"https://docs.bazel.build/versions/main/be/make-variables.html#location\">$(location)</a></code>" + | ||
| " expansion.", |
There was a problem hiding this comment.
The html doesn't get rendered in the git preview. Is it supposed to, or is this just for the docsite?
There was a problem hiding this comment.
Hmm. The html comes from upstream, https://github.com/bazelbuild/bazel-skylib/blob/main/rules/run_binary.bzl#L71. Looks good on the docsite https://docs.aspect.build/bazelbuild/bazel-skylib/1.2.1/docs/run_binary_doc_gen.html#run_binary-tool so I'm going to leave it.
gregmagolan
force-pushed
the
run_binary_with_dir
branch
from
ee35d14 to
9c0aa0a
Compare
| The rule uses a Bash command on Linux/macOS/non-Windows, and a cmd.exe command | ||
| on Windows (no Bash is required). | ||
|
|
||
| This fork of bazel-skylib's copy_file adds directory support. |
There was a problem hiding this comment.
there was a response on bazelbuild/bazel-skylib#323
I think we should go with copy_directory in place of copy_file(output_dir=True) so there's some chance of going upstream
There was a problem hiding this comment.
Sounds reasonable to me
| @@ -1,30 +1,9 @@ | |||
| "Helpers to expand make variables" | |||
There was a problem hiding this comment.
wow we had so much rules_nodejs legacy crap in here that wasn't really needed??
There was a problem hiding this comment.
Yeah. That was some old code from RNJ. We should flip it in RNJ on the next major as well.
No description provided.