This repository was archived by the owner on Feb 10, 2025. It is now read-only.
PD-257019 sanitize execution name bug fix #843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Are We Doing Here?
Execution name sanitization and unit test for stepfn
Here’s a more concise pointwise summary of the
sanitizeExecutionName
method:Purpose: Sanitizes execution names by replacing invalid characters and truncating length.
Input Validation:
IllegalArgumentException
fornull
or empty strings.Trimming: Removes leading and trailing whitespace.
Character Replacement: Replaces invalid characters (non-alphanumeric, non-hyphen, non-underscore) with underscores.
Validity Check:
IllegalArgumentException
if the sanitized name is empty or consists only of underscores.Length Truncation: Truncates the sanitized name to the last 69 characters if it exceeds this length.
Logging: Optionally logs the sanitized name if it differs from the original.
Return: Returns the sanitized execution name.
Tests: