#34 Support regex validation of property values #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pascallibenzi Changes done. |
pascallibenzi
approved these changes
Jul 20, 2022
|
Hello @martin-schulze-vireso. |
martin-schulze-vireso
approved these changes
Jul 20, 2022
vincent-zurczak
force-pushed
the
#34
branch
4 times, most recently
from
857340e to
ecdad4b
Compare
|
Hm, it seems I can only force thenmerge but the bats-detik team must approve for you to merge. I am currently on my phone so I cannot dig deeper. I will investigate this later. |
|
In fact, my last commit was not signed. |
|
Ready to be merged. @martin-schulze-vireso |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the syntax to verify property values against a regular expression.
BTW, I may ask one of my colleagues to perform reviews on this project, if no one else feels comfortable on the library and its usage. In which case we should discuss how this person could join the group.