Skip to content

calculate declination and total intensity #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

callumrollo
Copy link
Collaborator

What does your PR do?

Adds calculation of magnetic declination and total intensity for the purpose of compass correction.

This adds a small pure python dependency from https://github.com/IAGA-VMOD/ppigrf

It's an up to date package which is actively maintained and archived on zenodo.

What issue does this PR address

Resolves Issue #76

Testing

Added a test with a sanity check value

This time I didn't push an unrelated commit along with the addition

@callumrollo
Copy link
Collaborator Author

Tests are failing because ppigrf is not on conda-forge, only PyPI. Options are:

  • change the CI to use pip rather than conda-forge when running tests
  • add ppigrf to conda-forge
  • some other way of implementing the declination calculation

@callumrollo
Copy link
Collaborator Author

The maintainer of ppigrf kindly added it to conda forge, so I'm going to re-trigger the CI on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant