-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Laravel 12 support #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 12 support #1672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to adapt the CI workflows, otherwise we don't know if it works.
I think I've done that know .. to the best I know how, anyway. Feel free to propose further changes! |
Not there yet, but getting closer.
pro tip: try it locally, but for all |
Co-authored-by: KentarouTakeda <[email protected]>
Windows seems to be a bit icky about not escaping ^ in the requirements, but should be good now :) |
There's a note about that issue for Windows here: https://getcomposer.org/doc/articles/versions.md#writing-version-constraints (under the 'Caret Version Range' section) 🤯 |
Yeah I saw that but not sure how to cleanly do that in the yaml for windows only. |
Indeed, you wouldn't want that escaping in the yaml and it'd probably break for non-Windows contexts. I assume it's something that needs to be configured differently somehow by GitHub on their CI setup for Windows in terms of how it translates the version constraints to the CLI.. |
Heroes, thanks! |
Just putting this out there to get ahead of the curve on supporting Laravel 12 when it's released on 24th Feb 2025.