Skip to content

Laravel 12 support #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 11, 2025
Merged

Laravel 12 support #1672

merged 9 commits into from
Feb 11, 2025

Conversation

jonnott
Copy link
Contributor

@jonnott jonnott commented Feb 7, 2025

Just putting this out there to get ahead of the curve on supporting Laravel 12 when it's released on 24th Feb 2025.

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to adapt the CI workflows, otherwise we don't know if it works.

@jonnott
Copy link
Contributor Author

jonnott commented Feb 7, 2025

We also need to adapt the CI workflows, otherwise we don't know if it works.

I think I've done that know .. to the best I know how, anyway. Feel free to propose further changes!

@mfn
Copy link
Collaborator

mfn commented Feb 7, 2025

Not there yet, but getting closer.

orchestra/testbench needs to allow ^10 I guess (or the dev version, whichever works)

pro tip: try it locally, but for all illuminate/* packages temporarily just use ^12, then you'll see the dep conflicts quicker.

@barryvdh barryvdh merged commit dba153f into barryvdh:master Feb 11, 2025
32 checks passed
@barryvdh
Copy link
Owner

Windows seems to be a bit icky about not escaping ^ in the requirements, but should be good now :)

@jonnott
Copy link
Contributor Author

jonnott commented Feb 11, 2025

Windows seems to be a bit icky about not escaping ^ in the requirements, but should be good now :)

There's a note about that issue for Windows here: https://getcomposer.org/doc/articles/versions.md#writing-version-constraints (under the 'Caret Version Range' section) 🤯

@barryvdh
Copy link
Owner

Yeah I saw that but not sure how to cleanly do that in the yaml for windows only.

@jonnott
Copy link
Contributor Author

jonnott commented Feb 11, 2025

Yeah I saw that but not sure how to cleanly do that in the yaml for windows only.

Indeed, you wouldn't want that escaping in the yaml and it'd probably break for non-Windows contexts. I assume it's something that needs to be configured differently somehow by GitHub on their CI setup for Windows in terms of how it translates the version constraints to the CLI..

@jonnott jonnott deleted the patch-1 branch February 11, 2025 14:28
@mfn
Copy link
Collaborator

mfn commented Feb 12, 2025

Heroes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants