-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Allow adding custom Macroable classes. #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
laravel-ide-helper/src/Alias.php Lines 386 to 387 in 4d2728c
There are two problems with them:
I'm ok to continue and make the changes. However, could you tell me if you're interested in this or not? Thanks! |
I think this is okay to add. I would prefer to have the default macro class hardcoded, only add custom classes to the config. |
Hey @barryvdh Thanks for your help and the merge. Hence, it's obviously not compatible with this package Not sure whether you'd like to provide a special treatment for them? |
this break a lot, after regenerating my file (I don't do it often), most of my macros stopped working. |
Summary
Some packages, like Filament, implements their own version of the Macroable trait.
Spatie even made their own version.
This PR allow adding any macro class we want to detect in the config file.
Thanks,
Mathieu.
Type of change
Checklist
composer fix-style