Test cr #4
Test cr #4
Conversation
earlier hidden files were missing also now sorting files using last modified (used `--sort accessed` of ripgrep)
WalkthroughThis pull request updates various Neovim configuration files. A new "nvim" section has been added to the README. Keybindings for quickfix management have been adjusted, and theme settings have been altered by adding a commented rose-pine option and disabling certain line number highlights. The terminal color setting is switched off in the main configuration file along with an appended fillchars option. Changes in the plugin lock file remove several plugins while adding a new "neovim" entry. Additionally, the colorscheme configuration is reworked to focus solely on rose-pine, and support for Go is updated by adding a plugin in one file and removing a redundant one. Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
lua/custom/plugins/colorscheme.lua (1)
91-94:⚠️ Potential issueVerify theme availability.
Only gruvbox is being returned while rose-pine is configured but not included in the return statement.
Apply this diff to include rose-pine:
return { gruvbox, + rosepine, }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
README.md(1 hunks)after/plugin/keybinding.vim(0 hunks)after/plugin/theme.vim(2 hunks)init.lua(1 hunks)lazy-lock.json(1 hunks)lua/custom/plugins/colorscheme.lua(1 hunks)lua/custom/plugins/lsp.lua(1 hunks)lua/custom/plugins/telescope.lua(1 hunks)lua/custom/plugins/vim_go.lua(0 hunks)
💤 Files with no reviewable changes (2)
- lua/custom/plugins/vim_go.lua
- after/plugin/keybinding.vim
✅ Files skipped from review due to trivial changes (3)
- README.md
- after/plugin/theme.vim
- lua/custom/plugins/telescope.lua
🔇 Additional comments (4)
lua/custom/plugins/colorscheme.lua (1)
6-89: LGTM! Well-structured rose-pine configuration.The configuration is comprehensive and well-organized, with clear sections for variants, features, styles, and color mappings.
init.lua (2)
95-95: LGTM! Cosmetic improvement.Setting end-of-buffer character to space improves the visual appearance by removing the default
~characters.
38-38:❓ Verification inconclusive
Verify terminal color support.
Setting
termguicolorsto false might affect color rendering in terminals that support true colors. Consider keeping it enabled if your terminal supports it.
🌐 Web query:
What is the impact of disabling termguicolors in Neovim?💡 Result:
Disabling
termguicolorsin Neovim reverts color handling to the terminal's ANSI palette (typically 16 or 256 colors), impacting visual elements and compatibility:
Color Accuracy Reduction
- True 24-bit color support is disabled[1][6][7]. Colorschemes designed for
termguicolorsmay appear oversimplified or mismatched[6][8].- Example: A hex-based GUI color like
#FF5733falls back to the closest ANSI approximation[6][8].Theme Compatibility Issues
- Themes relying on
termguicolorsmay break or display incorrectly[6]. For instance:" Without termguicolors: " This hex-defined highlight group fails to apply as intended hi Comment guifg=#7f849c- Preconfigured themes like
srceryorcatppuccinmay lose fidelity[6][8].Transparency Handling
- While Vim historically struggled with transparency under
termguicolors[1][3], Neovim generally handles background transparency better via:However, some edge cases may still depend on terminal emulator settings[5][7].hi Normal guibg=NONE ctermbg=NONETerminal Environment Dependencies
- Colors inherit directly from the host terminal’s palette[2][7]. For example:
# Alacritty config (~/.config/alacritty/alacritty.yml) colors: primary: background: '#1e1e2e' # Affects Neovim if termguicolors=off- Requires manual ANSI color adjustments in terminal emulators like iTerm2 or Alacritty[2][5].
For most users, enabling
termguicolorsis recommended unless working with legacy terminals or tools that conflict with truecolor support[7][9].Citations:
- 1: Termguicolors disables terminal transparency, and ability to set custom fg/bg without side effects vim/vim#7849
- 2: https://groups.google.com/g/vim_dev/c/ibhLaq-YBHM
- 3: https://groups.google.com/g/vim_dev/c/OdHS_YAM1VM
- 4: https://groups.google.com/g/vim_dev/c/jSJbS40cF-c
- 5: tmux + neovim + termguicolors strange background color. neovim/neovim#7764
- 6: Theme doesn't look right without
termguicolorscatppuccin/vim#15- 7: https://gist.github.com/andersevenrud/015e61af2fd264371032763d4ed965b6
- 8: Colours come out with when running in NeoVim with termguicolors. srcery-colors/srcery-vim#36
- 9: http://neovim.io/doc/user/vim_diff.html
- 10: https://neovim.io/doc/user/faq.html
Action Required: Verify Terminal Color Setup & Validate Fillchars Change
- Terminal Colors: Disabling
termguicolorsforces Neovim to fall back to the terminal’s ANSI palette (typically 16 or 256 colors), which can lead to reduced color accuracy and mismatched themes—especially if you use colorschemes designed for true 24-bit color support. If your terminal supports true colors, consider keepingtermguicolorsenabled to retain optimal color fidelity.- Fillchars Update: The cosmetic change to append a custom character for the end-of-buffer (eob) is minor but should be verified to ensure it aligns with your overall UI design and doesn’t inadvertently affect visual consistency.
lazy-lock.json (1)
16-16: LGTM! Lock file updates align with plugin changes.The changes reflect:
- Addition of rose-pine theme ("neovim")
- Removal of other themes (nord, onedarkpro, solarized)
- Removal of vim-go (now configured in lsp.lua)
| local vim_go = { | ||
| "fatih/vim-go", | ||
| } |
There was a problem hiding this comment.
Include vim-go in the return statement and consider adding configuration.
The vim-go plugin is defined but not returned. Also, consider adding configuration options for better integration.
- Include vim-go in the return statement:
return {
jdtls,
typescript_tools,
lspconfig,
scala_metals,
+ vim_go,
}- Consider adding configuration options:
local vim_go = {
"fatih/vim-go",
+ config = function()
+ -- Disable vim-go's LSP features as we're using gopls
+ vim.g.go_gopls_enabled = 0
+ -- Enable auto formatting on save
+ vim.g.go_fmt_autosave = 1
+ -- Use goimports for formatting
+ vim.g.go_fmt_command = "goimports"
+ end,
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| local vim_go = { | |
| "fatih/vim-go", | |
| } | |
| local vim_go = { | |
| "fatih/vim-go", | |
| config = function() | |
| -- Disable vim-go's LSP features as we're using gopls | |
| vim.g.go_gopls_enabled = 0 | |
| -- Enable auto formatting on save | |
| vim.g.go_fmt_autosave = 1 | |
| -- Use goimports for formatting | |
| vim.g.go_fmt_command = "goimports" | |
| end, | |
| } | |
| return { | |
| jdtls, | |
| typescript_tools, | |
| lspconfig, | |
| scala_metals, | |
| vim_go, | |
| } |
Summary by CodeRabbit