Rename unsealer.image to bankVaults.image

[sagikazarmark]

Currently both the configurer and unsealer use the unsealer image config.

Rename it to bankVaults so that naming makes more sense.

[tanmay-pnaik]

This should be backwards compatible like: bank-vaults/vault-operator@203082c

[sagikazarmark]

Yes, it should.

[tanmay-pnaik]

I can help with this. 👍

[sagikazarmark]

Appreciate it, thank you!

[tanmay-pnaik]

@sagikazarmark Should this be implemented only for https://github.com/bank-vaults/vault-helm-chart/blob/main/vault/values.yaml#L250-L254 or for the entire unsealer block i.e. https://github.com/bank-vaults/vault-helm-chart/blob/main/vault/values.yaml#L250-L276? The former is pretty straightforward.

[sagikazarmark]

Good question...

I'd say it would be ideal if we could have a common block for everything that's shared between the unsealer and the configurer, but I can see why that could prove challenging.

Maybe we could use templating to filter the relevant keys from the unsealer section and recursively merge it with a new bankVaults section. I think that should be possible using template functions.

[tanmay-pnaik]

Having an issue with creating a template for unsealer.args, will work on it for some time.

[ramizpolic]

Hi @tanmay-pnaik, thanks for the interest, do you still need help with this? I can assist you and help out with setting everything up.

[tanmay-pnaik]

Hi @tanmay-pnaik, thanks for the interest, do you still need help with this? I can assist you and help out with setting everything up.

@ramizpolic That would be helpful. I'll raise a PR with my current changes and maybe we could then take it forward?

[ramizpolic]

Sounds good, whenever you are ready @tanmay-pnaik