This repository was archived by the owner on Jan 16, 2025. It is now read-only.
Bump ts and other libs #1699
Draft
Bump ts and other libs #1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSReds
commented
Mar 22, 2023
| @@ -1,18 +1,11 @@ | |||
| import cloneDeep from 'lodash/cloneDeep'; | |||
| import * as React from 'react'; | |||
| import styled from 'styled-components'; | |||
| import styled, { withTheme } from 'styled-components'; | |||
| import { ITerminalOptions, Terminal as Xterm } from 'xterm'; | |||
There was a problem hiding this comment.
the initialization of Xterm seems to be the problem for the error:
TypeError: Cannot read properties of undefined (reading 'indexOf')
at Object.6114 (node_modules/xterm/lib/webpack:/xterm/src/common/Platform.ts:43:14)
at exports (node_modules/xterm/lib/webpack:/xterm/webpack/bootstrap:19:68)
at Object.9312 (node_modules/xterm/lib/webpack:/xterm/src/browser/services/SelectionService.ts:11:1)
at exports (node_modules/xterm/lib/webpack:/xterm/webpack/bootstrap:19:68)
at Object.3236 (node_modules/xterm/lib/webpack:/xterm/src/browser/Terminal.ts:33:1)
at exports (node_modules/xterm/lib/webpack:/xterm/webpack/bootstrap:19:68)
at node_modules/xterm/lib/webpack:/xterm/src/browser/public/Terminal.ts:11:1
at node_modules/xterm/lib/xterm.js:1:275629
at node_modules/xterm/lib/xterm.js:1:275635
at node_modules/xterm/lib/webpack:/xterm/webpack/universalModuleDefinition:4:28
at Object.<anonymous> (node_modules/xterm/lib/webpack:/xterm/webpack/universalModuleDefinition:11:1)
at Object.<anonymous> (src/components/Terminal/index.tsx:3954:28)
at Object.<anonymous> (src/index.ts:6670:18)
JSReds
commented
Mar 22, 2023
Comment on lines
+170
to
+171
| "testPathIgnorePatterns": ["<rootDir>/src/components/Terminal", "<rootDir>/node_modules/xterm", "<rootDir>/node_modules/xterm/", "<rootDir>/node_modules/xterm/*", "node_modules/xterm", "node_modules/xterm/", "node_modules/xterm/*"], | ||
| "modulePathIgnorePatterns": ["<rootDir>/src/components/Terminal", "<rootDir>/node_modules/xterm", "<rootDir>/node_modules/xterm/", "<rootDir>/node_modules/xterm/*", "node_modules/xterm", "node_modules/xterm/", "node_modules/xterm/*"] |
JSReds
commented
Mar 22, 2023
| @@ -96,6 +96,7 @@ export { | |||
| } from './components/Table'; | |||
|
|
|||
| export { Accordion, AccordionProps } from './components/Accordion'; | |||
| /* istanbul ignore next */ | |||
Change-type: patch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
See: https://balena.zulipchat.com/#narrow/stream/346007-balena-io.2FbalenaCloud/topic/TS.20bump
still to solve:
Connects-to: #
See:
Depends-on:
Change-type: major|minor|patch
Contributor checklist
npm run generate-snapshotsReviewer Guidelines