Skip to content
This repository was archived by the owner on Jan 16, 2025. It is now read-only.

Make sort icon for table column headers remain on the same line as the text #1588

Merged
1 commit merged into from
May 10, 2022

Conversation

myarmolinsky
Copy link
Contributor

Make sort icon for table column headers remain on the same line as the text

Connects-to: https://github.com/balena-io/balena-ui/issues/5420
Change-type: patch
Signed-off-by: Matthew Yarmolinsky [email protected]


Contributor checklist
  • I have regenerated jest snapshots for any affected components with npm run generate-snapshots
Reviewer Guidelines
  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@myarmolinsky myarmolinsky self-assigned this May 10, 2022
@myarmolinsky myarmolinsky force-pushed the keep-sort-and-column-label-on-same-line branch 2 times, most recently from 31a94a2 to b28eb73 Compare May 10, 2022 12:42
…e text

Change-type: patch
Signed-off-by: Matthew Yarmolinsky <[email protected]>
@myarmolinsky myarmolinsky force-pushed the keep-sort-and-column-label-on-same-line branch from b28eb73 to fc2d5ad Compare May 10, 2022 13:03
@myarmolinsky
Copy link
Contributor Author

@balena-ci I self certify!

@ghost ghost merged commit 0680a7f into master May 10, 2022
@ghost ghost deleted the keep-sort-and-column-label-on-same-line branch May 10, 2022 13:35
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant