Skip to content

Add support for PBS v3.2.7 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Add support for PBS v3.2.7 #52

merged 2 commits into from
Sep 14, 2024

Conversation

clansty
Copy link
Contributor

@clansty clansty commented Jul 26, 2024

This PR add support for PBS v3.2.7

Tested build on x86_64

The following changes has been made, the progress cost me >5 hours:

  • Some of the existed patches shoudd be changed
  • The .cargo/config file has been renamed to .cargo/config.toml so we should add new filename to strip-cargo.bash
  • The test of proxmox-perl-rs/pve-rs not run, and has been removed by a new patch
  • proxmox-perl-rs/pve-rs adds dependences of libproxmox-rs-perl to load Proxmox::Lib::SslProbe needed for the test. But this leads to circular dependency. It's safe to remove the dependency
  • In package proxmox-backup, the Debian's cargo wrapper explains debian/cargo_home/config not found, and added a -Zavoid-dev-deps which is nightly feature to the real cargo, but did nothing good. So I replaced it with the real cargo
  • Maybe replacing the Debian cargo wrapper changed the rust target dir from target/$(DEB_HOST_RUST_TYPE)/release to target/release so I manually added an arg to cargo to define target dir. Generation of docs and some tests depends on it

@clansty
Copy link
Contributor Author

clansty commented Jul 26, 2024

The built container unable to run and shows Error: unable to start daemon - paths must not contain interior null bytes without any backtrace. I think we need to debug the rust code

Stack backtrace:
   0: anyhow::error::<impl core::convert::From<E> for anyhow::Error>::from
   1: proxmox_rest_server::command_socket::CommandSocket::spawn
   2: proxmox_backup_api::run::{{closure}}::{{closure}}
   3: tokio::runtime::context::runtime::enter_runtime
   4: tokio::runtime::runtime::Runtime::block_on
   5: proxmox_async::runtime::main
   6: proxmox_backup_api::main
   7: std::sys_common::backtrace::__rust_begin_short_backtrace
   8: std::rt::lang_start::{{closure}}
   9: std::rt::lang_start_internal
  10: main
  11: <unknown>
  12: __libc_start_main
  13: _start

@clansty
Copy link
Contributor Author

clansty commented Jul 26, 2024

Solved!

image

@maximko
Copy link

maximko commented Aug 27, 2024

please merge this one

Copy link
Owner

@ayufan ayufan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Let me validate everything and push new image.

@ayufan ayufan merged commit bb5c741 into ayufan:master Sep 14, 2024
@PPP01
Copy link

PPP01 commented Dec 3, 2024

It would be so great, to have this new image!

@ayufan ayufan mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants