Forked pod doesn't copy pod's labels

[yarinm]

I have a scenario that I'm using Azure MSI and aad-pod-identity to assign identities to pods (in order to retrieve credentials for several azure services). The way this integration works is by assigning a label to the pods.

When I use the fork feature it doesn't copy any of the original labels and it causes the pod to fail before the point I need to debug.

As I see it, fork should copy the labels of the original pod.

[calmkart]

kubectl-debug/pkg/plugin/cmd.go

Lines 558 to 566 in 5021027

	// copyAndStripPod copy the given pod template, strip the probes and labels,
	// and replace the entry point
	func copyAndStripPod(pod *corev1.Pod, targetContainer string) *corev1.Pod {
	copied := &corev1.Pod{
	ObjectMeta: *pod.ObjectMeta.DeepCopy(),
	Spec: *pod.Spec.DeepCopy(),
	}
	copied.Name = fmt.Sprintf("%s-%s-debug", pod.Name, uuid.NewUUID())
	copied.Labels = nil

is there some reson to strip the labels?

[aylei]

@yarinm @calmkart Labels may get Pod operated by Kubernetes controllers. e.g. being adopted by ReplicaSet controller then being deleted because the Pod count exceed the desired replica count, being added to the service endpoints and causing requests to fail.

[aylei]

For this scenario I think user should be able to retain certain labels while forking, this can be simply implemented by adding extra command parameters to the debug command. However, this makes the UX more complicated, so I am wondering if there is any better idea.

[calmkart]

For this scenario I think user should be able to retain certain labels while forking, this can be simply implemented by adding extra command parameters to the debug command. However, this makes the UX more complicated, so I am wondering if there is any better idea.

maybe adding a command parameter is a good solution. If there is no better way, I can do this work.

[calmkart]

fixed in #69

[aylei]

closed via #69