Fix (and ignore one!) type errors #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…writeTextFile, convert bigint to number in offset parameter usage, and ignore one type error that I do not understand 😅
Codecov Report
@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 66.75% 67.74% +0.98%
==========================================
Files 2 2
Lines 361 372 +11
Branches 33 34 +1
==========================================
+ Hits 241 252 +11
Misses 120 120
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thank you for your contribution! |
|
Hey @ayame113 I fixed up the PR and added tests for it - it actually works now, unlike my initial PR 😅 |
ayame113
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to handling ReadableStreams in writeFile and writeTextFile, convert bigint to number in offset parameter usage, and ignore one type error that I do not understand 😅
This change to the
writeFileAPI was introduced, from what I can tell, in v1.30 of deno (here). The change to the seek operations seem to have come from here (also in v1.30).This seems to pass the tests now, at least.
Not sure if this is entirely correct - could use a bit of guidance and review. Happy to adjust it as needed.