-
Notifications
You must be signed in to change notification settings - Fork 45
Build LLVM from source in CI #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
64712ed
to
a91ea1b
Compare
ac08a68
to
711e846
Compare
This separation doesn't buy us anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 1 of 3 files at r3, all commit messages.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @alessandrod and @tamird)
.github/workflows/release.yml
line 12 at r3 (raw file):
strategy: matrix: os: [ubuntu-latest, macos-latest, windows-latest]
What does this os mean? Didn't we only compile and cache llvm for linux?
b3960df
to
1ec7516
Compare
This disables testing with rustc's LLVM until our changes have been cherry-picked to their LLVM fork, and disables installing LLVM from apt until those changes are included in an LLVM release. This includes a manually-triggered release workflow that uploads binaries to github releases. We should eventually make this automatic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 5 files reviewed, all discussions resolved (waiting on @ajwerner and @alessandrod)
.github/workflows/release.yml
line 12 at r3 (raw file):
Previously, ajwerner wrote…
What does this os mean? Didn't we only compile and cache llvm for linux?
Done. Removed not-linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @alessandrod)
This change is