Skip to content

Build LLVM from source in CI #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Build LLVM from source in CI #79

merged 3 commits into from
Jul 25, 2023

Conversation

tamird
Copy link
Member

@tamird tamird commented Jul 24, 2023

This change is Reviewable

@tamird tamird requested review from ajwerner and alessandrod July 24, 2023 18:32
@tamird tamird force-pushed the llvm-from-source branch 6 times, most recently from 64712ed to a91ea1b Compare July 24, 2023 22:37
@tamird tamird force-pushed the llvm-from-source branch 9 times, most recently from ac08a68 to 711e846 Compare July 25, 2023 19:55
This separation doesn't buy us anything.
@tamird tamird force-pushed the llvm-from-source branch from 711e846 to 3dce157 Compare July 25, 2023 20:06
Copy link
Member

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 1 of 3 files at r3, all commit messages.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @alessandrod and @tamird)


.github/workflows/release.yml line 12 at r3 (raw file):

    strategy:
      matrix:
        os: [ubuntu-latest, macos-latest, windows-latest]

What does this os mean? Didn't we only compile and cache llvm for linux?

@tamird tamird force-pushed the llvm-from-source branch 4 times, most recently from b3960df to 1ec7516 Compare July 25, 2023 21:32
This disables testing with rustc's LLVM until our changes have been
cherry-picked to their LLVM fork, and disables installing LLVM from apt
until those changes are included in an LLVM release.

This includes a manually-triggered release workflow that uploads
binaries to github releases. We should eventually make this automatic.
@tamird tamird force-pushed the llvm-from-source branch from 1ec7516 to 5bfbcfe Compare July 25, 2023 22:11
Copy link
Member Author

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 5 files reviewed, all discussions resolved (waiting on @ajwerner and @alessandrod)


.github/workflows/release.yml line 12 at r3 (raw file):

Previously, ajwerner wrote…

What does this os mean? Didn't we only compile and cache llvm for linux?

Done. Removed not-linux.

Copy link
Member

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alessandrod)

@tamird tamird merged commit 7b4c207 into main Jul 25, 2023
@tamird tamird deleted the llvm-from-source branch July 25, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants