chore: Update to LLVM 20 #257
Conversation
|
Hmm... I'm not sure if linking llvm-sys 191.x to LLVM 20 will work. If yes, that's great. If not, we need to bump the LLVM version in llvm-sys first. I've already started preparing that change, I'm planning to make a PR next morning. |
|
Hum, interesting - the failing tests have just some mismatch in the DI/IR, but overall linking to LLVM 20 seems to work just fine. On a side note, I opened a PR in llvm-sys. |
tamird
force-pushed
the
llvm-20
branch
2 times, most recently
from
8debd49 to
2f13419
Compare
Latest Rust nightly switched to LLVM 20, so we need to update in order to support rustc-llvm-proxy.
|
@vadorovsky I don't have a Linux machine handy to test on. Could you see if you can find out why the DI is lacking this function? |
Sure, I will take care of that |
The previous code, which wasn't making any use of the return value of `my_function`, was optimized out after upgrading to LLVM 20. Using the return value prevents that.
For me, installing the latest |
|
@thomaseizinger what does "didn't work" mean? That's not actionable. |
It couldn't find an LLVM version to link against. Building llvm-sys failed. |
|
Oh, yeah, that won't work. Unfortunately everything is tightly coupled: rustc, LLVM, and bpf-linker must all be using the same LLVM version. |
That is what I figured. The README is currently outdated on that front :) Plus, I think it would be good to tell people to use Maybe we can also add a table that maps versions of |
|
IMO we should be looking to write the docs such that they're always correct, not such that the require constant updates. |
This change is