http: enable flush-on-worker-key-change for 1 worker #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the URL is templated and batching is enabled it does not matter how many workers we have, we need to close the batch when the partition key changes. The condition for the if statement was wrong for a long time, however since 70c704c it not only resulted in a missing error log and missing init fail, but we ran with flush-on-worker-key-change(no), messing up the batching. Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
bazsi
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the URL is templated and batching is enabled it does not matter how many workers we have, we
need to close the batch when the partition key changes.
The condition for the if statement was wrong for a long time, however since 70c704c it not only resulted in a missing error log and missing init fail, but we ran with
flush-on-worker-key-change(no), messing up the batching.Signed-off-by: Attila Szakacs [email protected]