WIP: the tip of my filterx performance efforts #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
filterx-perf-project
branch
4 times, most recently
from
6e3ce03 to
0b045c1
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
3 times, most recently
from
fbff61c to
5cab36c
Compare
This was referenced Jan 7, 2025
Merged
bazsi
force-pushed
the
filterx-perf-project
branch
6 times, most recently
from
d940c50 to
89e67ad
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
4 times, most recently
from
5be65da to
706b176
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
5 times, most recently
from
441b84d to
7beb087
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
3 times, most recently
from
7b7511f to
444d2ca
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
from
444d2ca to
6a704c7
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
from
6a704c7 to
dfdb06c
Compare
bazsi
force-pushed
the
filterx-perf-project
branch
from
dfdb06c to
1fb4980
Compare
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…a single expr Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Is a lot of complications and seems to slow things down due to its intensive use of thread local variables. RIP. Signed-off-by: Balazs Scheidler <[email protected]>
…alls Signed-off-by: Balazs Scheidler <[email protected]>
…strcmp calls" This reverts commit 1b1de84b984e139b3b1acdda5cae9de7e8dbf3ae.
Sometimes we already check if an object is a string, so no need to validate it again. Signed-off-by: Balazs Scheidler <[email protected]>
This reverts commit b2c0d28bd29ce04ee395af1e88cfb46f32733bbc.
This reverts commit aa87277aeda114bb2fee9c6eccf60c824fcc4701.
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…nctions The 64 bit versions should be generic enough and any CPU where performance really matters is 64 bit anyway. Signed-off-by: Balazs Scheidler <[email protected]>
Also cover existing functionality with tests. Signed-off-by: Balazs Scheidler <[email protected]>
The previous implementation formatted the port number in the reverse digit order, as it was using a function originally not intended to be exported from str-format.c Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
filterx-perf-project
branch
from
fc94589 to
0be199b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore this PR as it is not intended to be merged. It contains work-in-progress local patches I am yet to extract into separate pull requests.
It is rebased on top of my local merge of all related PRs, so I can maintain those branches separately as they get merged.