The installl.sh does not work correctly

[kallookoo]

When for some reason the GitHub API limit is exceeded the script tries to decompress the file when it is not.

Current code that fails to extract:

curl --silent --location --max-time "${TIMEOUT}" "${LINK}" | tar zxf - || {
    echo "Error downloading"
    exit 2
}

Suggestion:

curl --silent --location --fail --max-time "${TIMEOUT}" "${LINK}" -o "$GH_REPO_BIN" || {
    echo "Error downloading"
    exit 2
}
tar zxf "$GH_REPO_BIN" || exit 2

[axllent]

Thanks @kallookoo - I have made some changes to the install.sh script to handle for this, as well as a few other tweaks. Please will you confirm this is what you expected?

[kallookoo]

Yes, that's fine.
When I have a moment I'll make you a PR with some changes.

Thanks for everything!

[kallookoo]

Here you have a new version.
I don't make a PR so you are free to use it as you want, since I have changed a lot of things.

https://github.com/kallookoo/mailpit/blob/sh-install/install.sh

[axllent]

That's awesome @kallookoo - definitely a lot elegant than what I have, although I am a little concerned that it now requires bash to function, where before any shell (even sh) would actually work. Whilst I am aware that the instructions in the README use bash, I am unsure whether this may catch out some users which either don't have bash installed or use a different shell. Given that the Mailpit installation is automated in so many different environments, I suspect this change may break some systems.

I did spot an issue in your script though. If I run the following command as a non-privileged user (I know... but I was testing the error checking in your script):

$ bash install.sh --install-path /
cp: cannot create regular file '/mailpit': Permission denied
ERROR: Copying mailpit to "/" directory.
Installed successfully to "//mailpit"

... it seems the EXIT_CODE=$? isn't catching the error code here. I suspect the other commands in that elif section don't either.

[kallookoo]

Hi @axllent

I have updated install.sh to be compatible with sh and bash, if you run bash install.sh you are forced to use bash otherwise you use sh.

About the error when copying, usually in the OS it is not allowed to modify the root, for security reasons. But it is true that the “if elif fi” group did not work correctly.

I have tested the code on macOS and debian.

Regards

[axllent]

@kallookoo - that is amazing, well done! Sorry, I should have been clearer about the error - I did 100% expect it to fail because of permissions, but that is what I was testing and exactly how I caught the error in the first place :)

I can confirm that after a minor fix (curl --sfL ... has a double -- instead of a single -) it works perfectly with both sh and bash 🥳 I've also made a couple of other minor changes such as inheriting the INSTALL_PATH from the environment (if set) which allows that to be configured eg: INSTALL_PATH=/my/path sudo sh < <(curl -sL https://raw.githubusercontent.com/axllent/mailpit/develop/install.sh).

Awesome, I have now merged this into Mailpit. Thanks again for your valuable contribution!