Skip to content

fix(auxiliary)!: unpack interfaces with pointer #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

haiyizxx
Copy link
Contributor

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@haiyizxx haiyizxx requested a review from a team as a code owner July 24, 2024 20:13
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.71%. Comparing base (4dcedbb) to head (4a5facc).

Files Patch % Lines
x/auxiliary/types/msg_batch.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2165      +/-   ##
==========================================
+ Coverage   48.67%   48.71%   +0.03%     
==========================================
  Files         269      269              
  Lines       16095    16095              
==========================================
+ Hits         7834     7840       +6     
+ Misses       7656     7650       -6     
  Partials      605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haiyizxx haiyizxx force-pushed the fix-unpack-interfaces branch from 341ec60 to 4a5facc Compare July 25, 2024 01:35
@haiyizxx haiyizxx merged commit 8d22714 into main Jul 25, 2024
9 checks passed
@haiyizxx haiyizxx deleted the fix-unpack-interfaces branch July 25, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants