fix: rescue stuck filecoin key rotation on testnet #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyanokashi
approved these changes
Jul 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## releases/0.35.x #2157 +/- ##
===================================================
+ Coverage 47.92% 48.08% +0.15%
===================================================
Files 257 257
Lines 15945 15971 +26
===================================================
+ Hits 7642 7680 +38
+ Misses 7701 7685 -16
- Partials 602 606 +4 ☔ View full report in Codecov by Sentry. |
milapsheth
reviewed
Jul 18, 2024
haiyizxx
approved these changes
Jul 18, 2024
cgorenflo
added a commit
that referenced
this pull request
Jul 19, 2024
This reverts commit 2cc7129.
milapsheth
pushed a commit
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows vald processes to confirm filecoin key rotation https://calibration.filfox.info/en/tx/0xd9cc8d5f0238dfe360776ed9029835d8a470d4d30e46a43deb76f316c0bd5740, which was missed on testnet. All relevant data is either taken from the filecoin calibration testnet explorer or axelar testnet. This will be reverted once the confirmation has succeeded.
AXE-4449