Move enums from config into labels.hpp #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly a select few enums
hughcars
force-pushed
the
hughcars/refactor-labels
branch
from
1bd6b87 to
5027f91
Compare
hughcars
force-pushed
the
hughcars/refactor-labels
branch
from
5027f91 to
be49c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various enums from config are used more widely in the code base, or are shadowed in applications. This PR hoists them out and does some renaming of them and instances of them. This was part of the PostOperator refactor PR, but doing it completely got too large, so is easier to move out as it should change no functionality.