Skip to content

Add missing error for unsupported set-up configurations early #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

phdum-a
Copy link
Contributor

@phdum-a phdum-a commented May 20, 2025

Higher order far-field boundary conditions are only supported in driven system, since like wave-ports they have a non LRC frequency dependance. Technically, this is enforced when building the matrices here:

MFEM_VERIFY(farfield_bcs.Size() == 0 || order < 2 ||

It would be nice to enforce this along with all similar conditions in the config options. (e.g. we enforce no farfield be for the DC simulations in config).

PR is trivial, but would be nice for a second pair of eyes to double check logic / bool condition is correct.

@simlapointe
Copy link
Contributor

LGTM. Tested it on my end and it works as expected; warning is displayed only when using absorbing bc with order=2.

@simlapointe simlapointe enabled auto-merge May 20, 2025 19:04
@simlapointe simlapointe merged commit d5746ad into main May 20, 2025
27 checks passed
@simlapointe simlapointe deleted the phdum/eigen_warn branch May 20, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants